Messages in this thread |  | | Subject | Re: [PATCH v2 6/9] dt-bindings: media: rkisp1: move rockchip-isp1 bindings out of staging | From | Johan Jonker <> | Date | Thu, 23 Apr 2020 15:33:41 +0200 |
| |
Hi Helen,
> clocks: > items: > - description: ISP clock > - description: ISP AXI clock clock > - description: ISP AXI clock wrapper clock > - description: ISP AHB clock clock
Too many clocks here ^ Too many spaces here ^
> - description: ISP AHB wrapper clock
We can expect 4 to 5 clocks. With 5 clocks and a different description this layout is maybe not so handy.
As first change:
clocks: maxItems: 5 description: rk3399 clocks ISP clock ISP AXI clock ISP AXI wrapper clock ISP AHB clock ISP AHB wrapper clock
And then later:
clocks: maxItems: 5 description: rk3288 clocks ISP clock ISP AXI clock ISP AHB clock ISP Pixel clock ISP JPEG source clock rk3399 clocks ISP clock ISP AXI clock ISP AXI wrapper clock ISP AHB clock ISP AHB wrapper clock
With 4 clocks:
clocks: minItems: 4 maxItems: 5 description: rk1808 clocks rk3288 clocks rk3326 clocks rk3368 clocks rk3399 clocks [..]
> > clock-names: > items: > - const: clk_isp > - const: aclk_isp > - const: aclk_isp_wrap > - const: hclk_isp > - const: hclk_isp_wrap
On 4/3/20 6:15 PM, Helen Koike wrote: > Move rkisp1 bindings to Documentation/devicetree/bindings/media > > Verified with: > make ARCH=arm64 dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/rockchip-isp1.yaml > > Signed-off-by: Helen Koike <helen.koike@collabora.com> > --- > > V2: > - no changes > > .../devicetree/bindings/media/rockchip-isp1.yaml | 0 > 1 file changed, 0 insertions(+), 0 deletions(-) > rename {drivers/staging/media/rkisp1/Documentation => Documentation}/devicetree/bindings/media/rockchip-isp1.yaml (100%) > > diff --git a/drivers/staging/media/rkisp1/Documentation/devicetree/bindings/media/rockchip-isp1.yaml b/Documentation/devicetree/bindings/media/rockchip-isp1.yaml > similarity index 100% > rename from drivers/staging/media/rkisp1/Documentation/devicetree/bindings/media/rockchip-isp1.yaml > rename to Documentation/devicetree/bindings/media/rockchip-isp1.yaml >
|  |