lkml.org 
[lkml]   [2020]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] sched/isolation: Allow "isolcpus=" to skip unknown sub-parameters
Date
Peter Xu <peterx@redhat.com> writes:
> On Thu, Apr 02, 2020 at 01:29:14AM +0200, Thomas Gleixner wrote:
>> Peter Xu <peterx@redhat.com> writes:
>> >> + /*
>> >> + * Skip unknown sub-parameter and validate that it is not
>> >> + * containing an invalid character.
>> >> + */
>> >> + for (par = str, len = 0; isalpha(*str); str++, len++);
>> >> + if (*str != ',') {
>> >> + pr_warn("isolcpus: Invalid flag %*s\n", len, par);
>> >
>> > ... this will dump "isolcpus: Invalid flag domain1,3,5", is this what
>> > we wanted? Maybe only dumps "domain1"?
>>
>> No, it will dump: "domain1" at least if my understanding of is_alpha()
>> and the '%*s' format option is halfways correct
>
> It will dump "isolcpus: Invalid flag domain1,3,5". Do you mean "%.*s"
> instead?

Obviously.

> Another issue is even if to use "%.*s" it'll only dump "domain". How
> about something like (declare "illegal" as bool):
>
> /*
> * Skip unknown sub-parameter and validate that it is not
> * containing an invalid character.
> */
> for (par = str, len = 0; *str && *str != ','; str++, len++)
> if (!isalpha(*str))
> illegal = true;
>
> if (illegal) {
> pr_warn("isolcpus: Invalid flag %.*s\n", len, par);

You can achieve the same thing without the illegal indirection with

pr_warn("....", len + 1, par);

Thanks,

tglx

\
 
 \ /
  Last update: 2020-04-02 10:41    [W:0.084 / U:8.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site