lkml.org 
[lkml]   [2020]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 7/7] tty: serial_core: Add missing annotation for _unlock_and_check_sysrq()
On Tue, Mar 31, 2020 at 09:46:43PM +0100, Jules Irenge wrote:
> Sparse reports a warning at _unlock_and_check_sysrq()
>
> warning: context imbalance in uart_unlock_and_check_sysrq()
> - unexpected unlock
>
> The root cause is the missing annotation at _unlock_and_check_sysrq()
> Add the missing __releases(&port->lock) annotation.
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
> drivers/tty/serial/serial_core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
> index 76e506ee335c..32f93f03efce 100644
> --- a/drivers/tty/serial/serial_core.c
> +++ b/drivers/tty/serial/serial_core.c
> @@ -3121,6 +3121,7 @@ int uart_prepare_sysrq_char(struct uart_port *port, unsigned int ch)
> EXPORT_SYMBOL_GPL(uart_prepare_sysrq_char);
>
> void uart_unlock_and_check_sysrq(struct uart_port *port, unsigned long irqflags)
> + __releases(&port->lock)
> {
> int sysrq_ch;
>
> --
> 2.24.1
>

This is already in the tree, are you sure you are not working from an
older one?

greg k-h

\
 
 \ /
  Last update: 2020-04-16 16:34    [W:0.131 / U:3.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site