Messages in this thread |  | | Date | Wed, 15 Apr 2020 18:45:28 +0200 | From | Michał Mirosław <> | Subject | Re: [PATCH 5/7] mmc: sdhci: simplify clock frequency calculation |
| |
On Wed, Apr 15, 2020 at 04:54:33PM +0300, Adrian Hunter wrote: > On 2/04/20 2:54 pm, Michał Mirosław wrote: > > Make clock frequency calculations simpler by replacing loops > > with divide-and-clamp. > > I am sorry, but I am not really sure the simplification is worth the code > churn, risk of introducing new bugs, or validation effort. > > IMO, the loops, while perhaps inefficient, are not hard to understand.
I guess this is a kind of religious subject. ;-) I tend to prefer shorter and less-branchy code.
Best Regards, Michał Mirosław
|  |