[lkml]   [2020]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v3] mm: fix tick timer stall during deferred page init
On 01.04.20 17:42, Michal Hocko wrote:
> I am sorry but I have completely missed this patch.
> On Wed 11-03-20 20:38:48, Shile Zhang wrote:
>> When 'CONFIG_DEFERRED_STRUCT_PAGE_INIT' is set, 'pgdatinit' kthread will
>> initialise the deferred pages with local interrupts disabled. It is
>> introduced by commit 3a2d7fa8a3d5 ("mm: disable interrupts while
>> initializing deferred pages").
>> On machine with NCPUS <= 2, the 'pgdatinit' kthread could be bound to
>> the boot CPU, which could caused the tick timer long time stall, system
>> jiffies not be updated in time.
>> The dmesg shown that:
>> [ 0.197975] node 0 initialised, 32170688 pages in 1ms
>> Obviously, 1ms is unreasonable.
>> Now, fix it by restore in the pending interrupts for every 32*1204 pages
>> (128MB) initialized, give the chance to update the systemd jiffies.
>> The reasonable demsg shown likes:
>> [ 1.069306] node 0 initialised, 32203456 pages in 894ms
>> Fixes: 3a2d7fa8a3d5 ("mm: disable interrupts while initializing deferred pages").
> I dislike this solution TBH. It effectivelly conserves the current code
> and just works around the problem. Why do we hold the IRQ lock here in
> the first place? This is an early init code and a very limited code is
> running at this stage. Certainly nothing memory hotplug related which
> should be the only path really interested in the resize lock AFAIR.

Yeah, I don't think ACPI and friends are up yet.


David / dhildenb

 \ /
  Last update: 2020-04-01 17:51    [W:0.098 / U:0.772 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site