Messages in this thread |  | | Subject | Re: [PATCH v3 1/1] ppc/crash: Reset spinlocks during crash | From | Leonardo Bras <> | Date | Wed, 01 Apr 2020 20:53:31 -0300 |
| |
Hello Peter,
On Wed, 2020-04-01 at 11:26 +0200, Peter Zijlstra wrote: > You might want to add a note to your asm/spinlock.h that you rely on > spin_unlock() unconditionally clearing a lock. > > This isn't naturally true for all lock implementations. Consider ticket > locks, doing a surplus unlock will wreck your lock state in that case. > So anybody poking at the powerpc spinlock implementation had better know > you rely on this.
Good idea. I will add this to my changes and generate a v4.
Thank you, [unhandled content-type:application/pgp-signature] |  |