lkml.org 
[lkml]   [2020]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v8 11/14] KVM: selftests: Introduce after_vcpu_run hook for dirty log test
On Wed, Apr 01, 2020 at 09:03:22AM +0200, Andrew Jones wrote:
> On Tue, Mar 31, 2020 at 02:59:57PM -0400, Peter Xu wrote:
> > Provide a hook for the checks after vcpu_run() completes. Preparation
> > for the dirty ring test because we'll need to take care of another
> > exit reason.
> >
> > Since at it, drop the pages_count because after all we have a better
> > summary right now with statistics, and clean it up a bit.
>
> I don't see what you mean by "drop the pages_count", because it's still
> there. But otherwise
>
> Reviewed-by: Andrew Jones <drjones@redhat.com>

I think the pages_count was dropped in some versions, at least the 1st
version when I wrote the commit, but it must have went back during one
of the rebases upon dirty_log_test.c... To make it simple, I'll just
remove this paragraph and pick the r-b (assuming it's valid with that).

Thanks,

--
Peter Xu

\
 
 \ /
  Last update: 2020-04-02 01:24    [W:0.043 / U:6.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site