lkml.org 
[lkml]   [2020]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 2/2] KEYS: Avoid false positive ENOMEM error on key read
Date
Waiman Long <longman@redhat.com> wrote:

> + tmpbuf = kmalloc(tbuflen, GFP_KERNEL);

This would probably be better off using kvmalloc() - otherwise big objects
have to be constructed from runs of contiguous pages. But since all we're
doing is buffering for userspace, we don't care about that.

If you agree, we can address it with an additional patch.

David

\
 
 \ /
  Last update: 2020-03-09 17:32    [W:0.185 / U:8.948 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site