lkml.org 
[lkml]   [2020]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v1] power: supply: bq27xxx_battery: Silence deferred-probe error
From
Date
On 3/8/20 5:51 PM, Dmitry Osipenko wrote:
> The driver fails to probe with -EPROBE_DEFER if battery's power supply
> (charger driver) isn't ready yet and this results in a bit noisy error
> message in KMSG during kernel's boot up. Let's silence the harmless
> error message.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---


Reviewed-by: Andrew F. Davis <afd@ti.com>


> drivers/power/supply/bq27xxx_battery.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c
> index 195c18c2f426..664e50103eaa 100644
> --- a/drivers/power/supply/bq27xxx_battery.c
> +++ b/drivers/power/supply/bq27xxx_battery.c
> @@ -1885,7 +1885,10 @@ int bq27xxx_battery_setup(struct bq27xxx_device_info *di)
>
> di->bat = power_supply_register_no_ws(di->dev, psy_desc, &psy_cfg);
> if (IS_ERR(di->bat)) {
> - dev_err(di->dev, "failed to register battery\n");
> + if (PTR_ERR(di->bat) == -EPROBE_DEFER)
> + dev_dbg(di->dev, "failed to register battery, deferring probe\n");
> + else
> + dev_err(di->dev, "failed to register battery\n");
> return PTR_ERR(di->bat);
> }
>
>

\
 
 \ /
  Last update: 2020-03-09 13:53    [W:0.065 / U:0.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site