Messages in this thread Patch in this message |  | | Date | Fri, 06 Mar 2020 14:42:04 -0000 | From | "tip-bot2 for Qais Yousef" <> | Subject | [tip: sched/core] sched/rt: Allow pulling unfitting task |
| |
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 98ca645f824301bde72e0a51cdc8bdbbea6774a5 Gitweb: https://git.kernel.org/tip/98ca645f824301bde72e0a51cdc8bdbbea6774a5 Author: Qais Yousef <qais.yousef@arm.com> AuthorDate: Mon, 02 Mar 2020 13:27:19 Committer: Ingo Molnar <mingo@kernel.org> CommitterDate: Fri, 06 Mar 2020 12:57:28 +01:00
sched/rt: Allow pulling unfitting task
When implemented RT Capacity Awareness; the logic was done such that if a task was running on a fitting CPU, then it was sticky and we would try our best to keep it there.
But as Steve suggested, to adhere to the strict priority rules of RT class; allow pulling an RT task to unfitting CPU to ensure it gets a chance to run ASAP.
LINK: https://lore.kernel.org/lkml/20200203111451.0d1da58f@oasis.local.home/ Suggested-by: Steven Rostedt <rostedt@goodmis.org> Signed-off-by: Qais Yousef <qais.yousef@arm.com> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Signed-off-by: Ingo Molnar <mingo@kernel.org> Fixes: 804d402fb6f6 ("sched/rt: Make RT capacity-aware") Link: https://lkml.kernel.org/r/20200302132721.8353-5-qais.yousef@arm.com --- kernel/sched/rt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c index 29a8695..bcb1436 100644 --- a/kernel/sched/rt.c +++ b/kernel/sched/rt.c @@ -1656,8 +1656,7 @@ static void put_prev_task_rt(struct rq *rq, struct task_struct *p) static int pick_rt_task(struct rq *rq, struct task_struct *p, int cpu) { if (!task_running(rq, p) && - cpumask_test_cpu(cpu, p->cpus_ptr) && - rt_task_fits_capacity(p, cpu)) + cpumask_test_cpu(cpu, p->cpus_ptr)) return 1; return 0;
|  |