Messages in this thread |  | | Date | Tue, 31 Mar 2020 11:31:36 -0400 | From | Steven Rostedt <> | Subject | Re: [RFC][PATCH] objtool,ftrace: Implement UNWIND_HINT_RET_OFFSET |
| |
On Tue, 31 Mar 2020 13:16:52 +0200 Peter Zijlstra <peterz@infradead.org> wrote:
> @@ -235,8 +237,8 @@ SYM_INNER_LABEL(ftrace_regs_call, SYM_L_GLOBAL) > > /* If ORIG_RAX is anything but zero, make this a call to that */ > movq ORIG_RAX(%rsp), %rax > - cmpq $0, %rax > - je 1f > + testq %rax, %rax > + jz 1f > > /* Swap the flags with orig_rax */ > movq MCOUNT_REG_SIZE(%rsp), %rdi
Hi Peter,
Can you send this change as a separate patch as it has nothing to do with this current change, and is a clean up patch that stands on its own.
Thanks,
-- Steve
|  |