lkml.org 
[lkml]   [2020]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 0/2] use DEFINE_DEBUGFS_ATTRIBUTE instead of DEFINE_SIMPLE_ATTRIBUTE
Date
> From: Rohit Sarkar <rohitsarkar5398@gmail.com>
> Sent: Dienstag, 31. März 2020 13:50
> To: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Sa, Nuno <Nuno.Sa@analog.com>; Ardelean, Alexandru
> <alexandru.Ardelean@analog.com>; jic23@kernel.org;
> stefan.popa@analog.com; zhongjiang@huawei.com; linux-
> iio@vger.kernel.org; Bogdan, Dragos <Dragos.Bogdan@analog.com>;
> pmeerw@pmeerw.net; knaack.h@gmx.de; Hennerich, Michael
> <Michael.Hennerich@analog.com>; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 0/2] use DEFINE_DEBUGFS_ATTRIBUTE instead of
> DEFINE_SIMPLE_ATTRIBUTE
>
> Hey Nuno,
> > > > >
> > > > I don't have the exact parts that this patch is touching but I have other
> parts where this patch
> > > > applies and should be same. So, the idea to test this is to read the files in
> debugfs? Maybe also
> > > > some unbind + binding?
> > > >
> > > > I will try to test this still today...
> > >
> > > The stress test is to open the debugfs file, then unbind the device and then
> > > read from the still open debugfs file.
> > Yes, also just to be sure, we need to test DEFINE_DEBUGFS_ATTRIBUTE
> > along with debugfs_create_file_unsafe. I will send out another patch
> > that changes debugfs_create_file to debugfs_create_file_unsafe and then
> > that can be tested.
> Have sent out a v2 that is ready to be tested

So I tested your changes in a different HW but the principle is the same.
It worked as expected. Unbinding the device and doing a read on an opened file
descriptor afterwards returns error...

- Nuno Sá
> > > - Lars
> >
> > Thanks,
> > Rohit
> Thanks,
> Rohit

\
 
 \ /
  Last update: 2020-03-31 17:31    [W:0.053 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site