lkml.org 
[lkml]   [2020]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 5.5 102/170] scripts/dtc: Remove redundant YYLOC global declaration
From
Date
Hi Greg,

>> $ sed -i 's;scripts/dtc/dtc-lexer.l;scripts/dtc/dtc-lexer.lex.c_shipped;g' \
>> queue-{4.4,4.9,4.14}/scripts-dtc-remove-redundant-yyloc-global-declaration.patch
>> If you would prefer a set of patches, let me know.
> Should I just drop the patch from 4.4, 4.9, and 4.14 instead?

as the original author of the patch, I am not sure why it was backported to the LTS releases (unless enablement for gcc 10.x or
other new toolchains is a requirement, which I'm not aware of).

However I think the sed above on the *patch* means that the patch will *only* modify the generated sources, not the input sources. I think
it would be better to patch both *input* and *generated* sources, or backport the generate-at-runtime patch as well (which might be
even further outside the stable policy).

Not knowing why it was backported, I would suggest to just dequeue the patch from the older trees.

Greetings,
Dirk

\
 
 \ /
  Last update: 2020-03-31 13:52    [W:0.127 / U:0.592 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site