lkml.org 
[lkml]   [2020]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 1/2] dt-bindings: mailbox: Add the Spreadtrum mailbox documentation
On Wed, Apr 1, 2020 at 1:40 AM Rob Herring <robh@kernel.org> wrote:
>
> On Mon, Mar 23, 2020 at 02:13:46PM +0800, Baolin Wang wrote:
> > From: Baolin Wang <baolin.wang@unisoc.com>
> >
> > Add the Spreadtrum mailbox documentation.
> >
> > Signed-off-by: Baolin Wang <baolin.wang@unisoc.com>
> > Signed-off-by: Baolin Wang <baolin.wang7@gmail.com>
> > ---
> > Changes from v1:
> > - Add 'additionalProperties'.
> > - Split description for each entry.
> > ---
> > .../devicetree/bindings/mailbox/sprd-mailbox.yaml | 62 ++++++++++++++++++++++
> > 1 file changed, 62 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml
> > new file mode 100644
> > index 0000000..0848b18
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml
> > @@ -0,0 +1,62 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: "http://devicetree.org/schemas/mailbox/sprd-mailbox.yaml#"
> > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> > +
> > +title: Spreadtrum mailbox controller bindings
> > +
> > +maintainers:
> > + - Orson Zhai <orsonzhai@gmail.com>
> > + - Baolin Wang <baolin.wang7@gmail.com>
> > + - Chunyan Zhang <zhang.lyra@gmail.com>
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - sprd,sc9860-mailbox
> > +
> > + reg:
> > + items:
> > + - description: inbox registers' base address
> > + - description: outbox registers' base address
>
> > + minItems: 2
>
> This is redundant, drop it.

OK.

>
> > +
> > + interrupts:
> > + items:
> > + - description: inbox interrupt
> > + - description: outbox interrupt
> > + minItems: 2
>
> Same here.

Sure.

>
> With that,
>
> Reviewed-by: Rob Herring <robh@kernel.org>

Thanks for your comments.

--
Baolin Wang

\
 
 \ /
  Last update: 2020-04-01 04:16    [W:0.053 / U:1.904 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site