lkml.org 
[lkml]   [2020]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 2/2] KVM: LAPIC: Don't need to clear IPI delivery status in x2apic mode
From
Date
On 01/04/20 02:19, Wanpeng Li wrote:
> - /* No delay here, so we always clear the pending bit */
> - val &= ~(1 << 12);
> + /* Immediately clear Delivery Status in xAPIC mode */
> + if (!apic_x2apic_mode(apic))
> + val &= ~(1 << 12);

This adds a conditional, and the old behavior was valid according to the
SDM: "software should not assume the value returned by reading the ICR
is the last written value".

Paolo

\
 
 \ /
  Last update: 2020-04-01 02:35    [W:0.063 / U:1.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site