Messages in this thread |  | | Date | Tue, 31 Mar 2020 17:22:51 -0700 | From | Sandeep Patil <> | Subject | Re: [PATCH v4 2/4] power_supply: Add additional health properties to the header |
| |
On Tue, Mar 10, 2020 at 03:09:37PM -0500, Dan Murphy wrote: > Hello > > On 3/6/20 5:55 PM, Sandeep Patil wrote: > > Hi Sebastian, > > > > On Fri, Jan 17, 2020 at 02:06:58AM +0100, Sebastian Reichel wrote: > > > Hi, > > > > > > On Thu, Jan 16, 2020 at 11:50:37AM -0600, Dan Murphy wrote: > > > > Add HEALTH_WARM, HEALTH_COOL and HEALTH_HOT to the health enum. > > > > > > > > Signed-off-by: Dan Murphy <dmurphy@ti.com> > > > > --- > > > Looks good. But I will not merge it without a user and have comments > > > for the driver. > > Android has been looking for these properties for a while now [1]. > > It was added[2] when we saw that the manufacturers were implementing these > > properties in the driver. I didn't know the properties were absent upstream > > until yesterday. Somebody pointed out in our ongoing effort to make sure > > all core kernel changes that android depends on are present upstream. > > > > I think those values are also propagated in application facing APIs in > > Android (but I am not sure yet, let me know if that's something you want > > to find out). > > > > I wanted to chime in and present you a 'user' for this if that helps. > > We have re-submitted the BQ25150/155 driver that would be the user and we > have 2 more for review that will use the new definitions
Dan / Sebastian, I wasn't able to find the subsequent patches that add the 3 health properties, so I'm assuming this patch is still "out-of-tree".
I was hoping against that so we (Android) aren't unnecessarily diverging from upstream. However, I have now just cherry-picked this patch[1] for the next Android release.
Sebastian, since these appear in JEITA spec, will the same patch with additions to the commit message saying so be enough?
Thanks, - ssp
1. https://android-review.googlesource.com/c/kernel/common/+/1275596
> > Dan >
|  |