[lkml]   [2020]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v4 2/4] SFH: PCI driver to add support of AMD sensor fusion Hub using HID framework
On Tue, Mar 31, 2020 at 4:26 PM Shah, Nehal-bakulchandra
<> wrote:
> On 3/31/2020 6:01 PM, Richard Neumann wrote:
> > Not a real review, but your patch series seems to be repeating a lot
> > from drivers/i2c/busses/i2c-amd-mp2*.
> > Is there any chance we could re-use the code?
> > E.g. the AMD_C2P_* definitions from drivers/i2c/busses/i2c-amd-mp2.h?
> Thanks for the mail. Yes there are some common structures, however as of now we have kept separately considering both
> are part of different sub systems. But may be will consider this input for future enhancement.

It can be done in a form of shared definitions at least in
include/linux/platform_data/x86/amd-mp2.h or alike ...

With Best Regards,
Andy Shevchenko

 \ /
  Last update: 2020-03-31 19:25    [W:0.047 / U:0.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site