Messages in this thread |  | | Date | Tue, 31 Mar 2020 09:29:10 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v1] driver core: Fix handling of fw_devlink=permissive |
| |
On Mon, Mar 30, 2020 at 11:18:01PM -0700, Saravana Kannan wrote: > On Mon, Mar 30, 2020 at 10:43 PM Marek Szyprowski > <m.szyprowski@samsung.com> wrote: > > > > Hi, > > > > On 2020-03-31 04:28, Saravana Kannan wrote: > > > When commit 8375e74f2bca ("driver core: Add fw_devlink kernel > > > commandline option") added fw_devlink, it didn't implement "permissive" > > > mode correctly. > > > > > > That commit got the device links flags correct to make sure unprobed > > > suppliers don't block the probing of a consumer. However, if a consumer > > > is waiting for mandatory suppliers to register, that could still block a > > > consumer from probing. > > > > > > This commit fixes that by making sure in permissive mode, all suppliers > > > to a consumer are treated as a optional suppliers. So, even if a > > > consumer is waiting for suppliers to register and link itself (using the > > > DL_FLAG_SYNC_STATE_ONLY flag) to the supplier, the consumer is never > > > blocked from probing. > > > > > > Fixes: 8375e74f2bca ("driver core: Add fw_devlink kernel commandline option") > > > Reported-by: Marek Szyprowski <m.szyprowski@samsung.com> > > > Signed-off-by: Saravana Kannan <saravanak@google.com> > > > --- > > > Hi Marek, > > > > > > If you pull in this patch and then add back in my patch that created the > > > boot problem for you, can you see if that fixes the boot issue for you? > > > > Indeed, this fixes booting on my Raspberry Pi3/4 boards with linux > > next-20200327. Thanks! :) > > Hi Marek, > > Thanks for testing, but I'm not able to find the tag next-20200327. I > can only find next-20200326 and next-20200330. I was just trying to > make sure that next-20200327 doesn't have the revert Greg did. I'm > guessing you meant next-20200326? > > > Tested-by: Marek Szyprowski <m.szyprowski@samsung.com> > > Thanks! > > Greg, > > Can you pull in my fix and then revert the revert?
After 5.7-rc1 is out I will, thanks.
greg k-h
|  |