lkml.org 
[lkml]   [2020]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v5 2/2] iio: proximity: Add driver support for vcnl3020 proximity sensor
On Mon, Mar 30, 2020 at 6:27 PM Ivan Mikhaylov <i.mikhaylov@yadro.com> wrote:
>
> Proximity sensor driver based on light/vcnl4000.c code.
> For now supports only the single on-demand measurement.
>
> The VCNL3020 is a fully integrated proximity sensor. Fully
> integrated means that the infrared emitter is included in the
> package. It has 16-bit resolution. It includes a signal
> processing IC and features standard I2C communication
> interface. It features an interrupt function.

Still my tag applies, but
I have few more comments below.

...

> +#define VCNL_DRV_NAME "vcnl3020"
> +#define VCNL_REGMAP_NAME "vcnl3020_regmap"

I'm wondering why you need the second one.

...

> + rc = device_property_read_u32(data->dev, "vishay,led-current-milliamp",
> + &led_current);

> + if (rc == 0) {
> + rc = regmap_write(data->regmap, VCNL_LED_CURRENT, led_current);
> + if (rc)
> + dev_err(data->dev,
> + "Error (%d) setting LED current", rc);
> + }
> +
> + return rc;

Why not to use standard pattern, i.e.

if (rc)
return rc;
...
rc = regmap_write(...);

?

...

> + if (rc) {
> + dev_err(data->dev,

> + "vcnl3020_measure() failed with error (%d)", rc);

Perhaps you keep same pattern for error messages as in previous function(s).

> + goto err_unlock;
> + }

> + rc = regmap_bulk_read(data->regmap, VCNL_PS_RESULT_HI, &res, 2);

sizeof(res)

> + if (rc)
> + goto err_unlock;

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2020-03-30 21:08    [W:0.100 / U:5.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site