lkml.org 
[lkml]   [2020]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 4/5] MIPS: DTS: Loongson64: Add PCI Controller Node
From


于 2020年3月30日 GMT+08:00 下午11:37:21, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> 写到:
>Hello!
>
>On 03/30/2020 02:42 PM, Jiaxun Yang wrote:
>
>> Add PCI Host controller node for Loongson64 with RS780E PCH dts.
>> Note that PCI interrupts are probed via legacy way, as different
>> machine have different interrupt arrangement, we can't cover all
>> of them in dt.
>>
>> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
>> ---
>> arch/mips/boot/dts/loongson/rs780e-pch.dtsi | 17 ++++++++++++++++-
>> 1 file changed, 16 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/mips/boot/dts/loongson/rs780e-pch.dtsi
>b/arch/mips/boot/dts/loongson/rs780e-pch.dtsi
>> index 45c54d555fa4..f09599a4b9d7 100644
>> --- a/arch/mips/boot/dts/loongson/rs780e-pch.dtsi
>> +++ b/arch/mips/boot/dts/loongson/rs780e-pch.dtsi
>> @@ -5,10 +5,25 @@ bus@10000000 {
>> compatible = "simple-bus";
>> #address-cells = <2>;
>> #size-cells = <2>;
>> - ranges = <0 0x10000000 0 0x10000000 0 0x10000000
>> + ranges = <0 0x00000000 0 0x00000000 0 0x00010000 /* ioports */
>> + 0 0x10000000 0 0x10000000 0 0x10000000
>> 0 0x40000000 0 0x40000000 0 0x40000000
>> 0xfd 0xfe000000 0xfd 0xfe000000 0 0x2000000 /* PCI Config Space
>*/>;
>>
>> + pci@1a000000 {
>> + compatible = "loongson,rs780e-pci";
>> + device_type = "pci";
>> + #address-cells = <3>;
>> + #size-cells = <2>;
>> + #interrupt-cells = <0x1>;
>
> No need for 0x.
>
>> +
>> + reg = <0 0x1a000000 0 0x02000000>;
>> +
>> + ranges = <0x01000000 0x0 0x00004000 0x0 0x00004000 0x0
>0x00004000>,
>> + <0x02000000 0x0 0x40000000 0x0 0x40000000 0x0 0x40000000>;
>
> No need for 0x before 0 here either. And why double spaces?

Thanks. Will fix in next version.

The space was intent to split address and size but it seems unnecessary.

>
>> +
>> + };
>> +
>> isa {
>> compatible = "isa";
>> #address-cells = <2>;
>>
>
>MBR, Sergei

--
Jiaxun Yang

\
 
 \ /
  Last update: 2020-03-30 17:50    [W:0.038 / U:2.772 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site