lkml.org 
[lkml]   [2020]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 02/39] MIPS: loongson64: Add header files path prefix
From


于 2020年3月30日 GMT+08:00 下午6:00:19, maobibo <maobibo@loongson.cn> 写到:
>
>
>On 03/30/2020 04:55 PM, Jiaxun Yang wrote:
>>
>>
>> 于 2020年3月30日 GMT+08:00 下午4:38:51, bibo mao <maobibo@loongson.cn> 写到:
>>> Remove header files from arch/mips/include/asm/mach-loongson64
>>> to arch/mips/loongson64/include/mach
>>>
>>> Signed-off-by: bibo mao <maobibo@loongson.cn>
>>
>> Hi Bibo,
>>
>> Thanks for your patch.
>>
>> What's your intention?
>> Did you meet any problem about headers?
>>
>
>Hi Jiaxun,
>
>When I add irqchip support for mips kvm, file virt/kvm/irqchip.c
>requires local header file arch/mips/kvm/irq.h, it fails to compile.
>Since there is file with the same name located at:
> arch/mips/include/asm/mach-generic/irq.h
> arch/mips/include/asm/mach-loongson64/irq.h
>
>The compiler fails to choose the correct header file irq.h,

btw: I checked Loongson's KVM implementation in their out-of-tree 3.10 kernel and found they're emulating everything
in Kernel, like csr, irqchip of LS7A, extioi of 3A4000, even cpufreq.

This is making the whole thing unnecessarily complex.

If you are trying to mainline Loongson KVM support then please avoid do like this.

Please reference how Arm define their virt machine in QEMU.

We're not x86, we don't have to run into historical limitations.

Thanks

>
>regards
>bibo,mao
>
--
Jiaxun Yang

\
 
 \ /
  Last update: 2020-03-31 05:57    [W:0.039 / U:3.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site