lkml.org 
[lkml]   [2020]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next v3 00/12] ethtool netlink interface, part 4
Sat, Mar 28, 2020 at 12:00:58AM CET, mkubecek@suse.cz wrote:
>Implementation of more netlink request types:
>
> - coalescing (ethtool -c/-C, patches 2-4)
> - pause parameters (ethtool -a/-A, patches 5-7)
> - EEE settings (--show-eee / --set-eee, patches 8-10)
> - timestamping info (-T, patches 11-12)
>
>Patch 1 is a fix for netdev reference leak similar to commit 2f599ec422ad
>("ethtool: fix reference leak in some *_SET handlers") but fixing a code
>
>Changes in v3
> - change "one-step-*" Tx type names to "onestep-*", (patch 11, suggested
> by Richard Cochran
> - use "TSINFO" rather than "TIMESTAMP" for timestamping information
> constants and adjust symbol names (patch 12, suggested by Richard
> Cochran)
>
>Changes in v2:
> - fix compiler warning in net_hwtstamp_validate() (patch 11)
> - fix follow-up lines alignment (whitespace only, patches 3 and 8)
>which is only in net-next tree at the moment.
>
>Michal Kubecek (12):
> ethtool: fix reference leak in ethnl_set_privflags()
> ethtool: provide coalescing parameters with COALESCE_GET request
> ethtool: set coalescing parameters with COALESCE_SET request
> ethtool: add COALESCE_NTF notification
> ethtool: provide pause parameters with PAUSE_GET request
> ethtool: set pause parameters with PAUSE_SET request
> ethtool: add PAUSE_NTF notification
> ethtool: provide EEE settings with EEE_GET request
> ethtool: set EEE settings with EEE_SET request
> ethtool: add EEE_NTF notification
> ethtool: add timestamping related string sets
> ethtool: provide timestamping information with TSINFO_GET request

FWIW, this looks fine to me.
set-
Acked-by: Jiri Pirko <jiri@mellanox.com>

Thanks Michal!

\
 
 \ /
  Last update: 2020-03-28 11:09    [W:0.127 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site