Messages in this thread |  | | Date | Sat, 28 Mar 2020 13:03:41 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] getdelays: Fix netlink attribute length |
| |
On Fri, 27 Mar 2020 11:31:11 -0600 David Ahern <dsahern@kernel.org> wrote:
> A recent change to the netlink code: > 6e237d099fac ("netlink: Relax attr validation for fixed length types") > logs a warning when programs send messages with invalid attributes > (e.g., wrong length for a u32). Yafang reported this error message > for tools/accounting/getdelays.c. > > send_cmd() is wrongly adding 1 to the attribute length. As noted in > include/uapi/linux/netlink.h nla_len should be NLA_HDRLEN + payload > length, so drop the +1.
Thanks.
> Fixes: 9e06d3f9f6b1 ("per task delay accounting taskstats interface: documentation fix") > Signed-off-by: David Ahern <dsahern@kernel.org> > Tested-by: Yafang Shao <laoar.shao@gmail.com>
I'll add Reported-by: as well.
> Cc: Johannes Berg <johannes@sipsolutions.net> > Cc: Shailabh Nagar <nagar@watson.ibm.com>
Is this worth a cc:stable?
|  |