Messages in this thread |  | | Subject | Re: [PATCH v5 4/5] power: supply: Add support for mps mp2629 battery charger | From | saravanan sekar <> | Date | Sat, 28 Mar 2020 12:29:43 +0100 |
| |
Hi Andy,
On 28/03/20 12:02 pm, Andy Shevchenko wrote: > On Sat, Mar 28, 2020 at 2:12 AM Saravanan Sekar <sravanhome@gmail.com> wrote: >> The mp2629 provides switching-mode battery charge management for >> single-cell Li-ion or Li-polymer battery. Driver supports the >> access/control input source and battery charging parameters. > ... > >> +#include <linux/module.h> >> +#include <linux/of_device.h> > Missed header bits.h. > > ... > >> + ret = iio_read_channel_processed(charger->iiochan[ch], &chval); >> + if (ret < 0) > Is it possible to get positive returned value? Really not for processed >> + return ret; > ... > >> + val->intval = (rval * props[fld].step) + props[fld].min; > Too many parentheses. > > ... > >> + return ((psp == POWER_SUPPLY_PROP_PRECHARGE_CURRENT) || >> + (psp == POWER_SUPPLY_PROP_CHARGE_TERM_CURRENT) || >> + (psp == POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT) || >> + (psp == POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE)); > Ditto. I think I misunderstood you previous review comment "Redundant parentheses", no sure what is the expectation > > ... > >> + return ((psp == POWER_SUPPLY_PROP_INPUT_VOLTAGE_LIMIT) || >> + (psp == POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT)); > Ditto. > > ... > >> + return sprintf(buf, "%d mohm\n", rval); > Hmm... For units we usually have separate node, but it is up to > maintainer, I dunno what the common practice is there. > > ... > >> + int val; >> + int ret; >> + >> + ret = kstrtoint(buf, 10, &val); >> + if (ret) >> + return ret; >> + >> + if (val < 0 && val > 140) > What the point to convert negative values in the first place? kstrtouint() Done >> + return -ERANGE; > ... > >> + struct power_supply_config psy_cfg = {NULL}; > { 0 } > NULL to make compiler happy.
|  |