lkml.org 
[lkml]   [2020]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v5 4/5] power: supply: Add support for mps mp2629 battery charger
On Sat, Mar 28, 2020 at 2:12 AM Saravanan Sekar <sravanhome@gmail.com> wrote:
>
> The mp2629 provides switching-mode battery charge management for
> single-cell Li-ion or Li-polymer battery. Driver supports the
> access/control input source and battery charging parameters.

...

> +#include <linux/module.h>
> +#include <linux/of_device.h>

Missed header bits.h.

...

> + ret = iio_read_channel_processed(charger->iiochan[ch], &chval);

> + if (ret < 0)

Is it possible to get positive returned value?

> + return ret;

...

> + val->intval = (rval * props[fld].step) + props[fld].min;

Too many parentheses.

...

> + return ((psp == POWER_SUPPLY_PROP_PRECHARGE_CURRENT) ||
> + (psp == POWER_SUPPLY_PROP_CHARGE_TERM_CURRENT) ||
> + (psp == POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT) ||
> + (psp == POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE));

Ditto.

...

> + return ((psp == POWER_SUPPLY_PROP_INPUT_VOLTAGE_LIMIT) ||
> + (psp == POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT));

Ditto.

...

> + return sprintf(buf, "%d mohm\n", rval);

Hmm... For units we usually have separate node, but it is up to
maintainer, I dunno what the common practice is there.

...

> + int val;
> + int ret;
> +
> + ret = kstrtoint(buf, 10, &val);
> + if (ret)
> + return ret;
> +

> + if (val < 0 && val > 140)

What the point to convert negative values in the first place? kstrtouint()

> + return -ERANGE;

...

> + struct power_supply_config psy_cfg = {NULL};

{ 0 }

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2020-03-28 12:03    [W:0.085 / U:1.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site