lkml.org 
[lkml]   [2020]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v5 3/5] iio: adc: mp2629: Add support for mp2629 ADC driver
On Sat, Mar 28, 2020 at 2:12 AM Saravanan Sekar <sravanhome@gmail.com> wrote:
>
> Add support for 8-bit resolution ADC readings for input power
> supply and battery charging measurement. Provides voltage, current
> readings to mp2629 power supply driver.

...

> + ret = regmap_read(info->regmap, chan->address, &rval);
> + if (ret < 0)

' < 0' is not needed for regmap call.

..

> + case MP2629_INPUT_CURRENT:
> + *val = 133;
> + *val2 = 10;
> + return IIO_VAL_FRACTIONAL;
> +
> + default:
> + return -EINVAL;
> + }
> +
> + default:
> + return -EINVAL;
> + }

> +
> + return 0;

Do you really need this? Looks to me as dead code.

...

> + indio_dev->name = dev_name(dev);

Shouldn't be this a part number?
I heard something, so, I might be mistaken, but I hope maintainers
will help here.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2020-03-28 11:53    [W:0.103 / U:3.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site