lkml.org 
[lkml]   [2020]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v5 2/5] mfd: mp2629: Add support for mps battery charger
From
Date
Hi Andy,

On 28/03/20 11:45 am, Andy Shevchenko wrote:
> On Sat, Mar 28, 2020 at 2:12 AM Saravanan Sekar <sravanhome@gmail.com> wrote:
>> mp2629 is a highly-integrated switching-mode battery charge management
>> device for single-cell Li-ion or Li-polymer battery.
>>
>> Add MFD core enables chip access for ADC driver for battery readings,
>> and a power supply battery-charger driver
> ...
>
>> +#ifndef __MP2629_H__
>> +#define __MP2629_H__
>> +#include <linux/device.h>
>> +#include <linux/regmap.h>
>> +#include <linux/types.h>
> None of these header is in use here.
>
> struct device;
> struct regmap;
>
> would be enough.

Yesterday I conveyed to you that Lee is not recommended to use forward
declaration and asked me

to use includes, then you agreed with the same. Again same comments !!
sorry I am lost.

>> +struct mp2629_info {
>> + struct device *dev;
>> + struct regmap *regmap;
>> +};
>> +
>> +#endif

\
 
 \ /
  Last update: 2020-03-28 11:52    [W:0.070 / U:3.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site