Messages in this thread |  | | Subject | Re: [PATCH v5 2/5] mfd: mp2629: Add support for mps battery charger | From | saravanan sekar <> | Date | Sat, 28 Mar 2020 11:51:47 +0100 |
| |
Hi Andy,
On 28/03/20 11:45 am, Andy Shevchenko wrote: > On Sat, Mar 28, 2020 at 2:12 AM Saravanan Sekar <sravanhome@gmail.com> wrote: >> mp2629 is a highly-integrated switching-mode battery charge management >> device for single-cell Li-ion or Li-polymer battery. >> >> Add MFD core enables chip access for ADC driver for battery readings, >> and a power supply battery-charger driver > ... > >> +#ifndef __MP2629_H__ >> +#define __MP2629_H__ >> +#include <linux/device.h> >> +#include <linux/regmap.h> >> +#include <linux/types.h> > None of these header is in use here. > > struct device; > struct regmap; > > would be enough.
Yesterday I conveyed to you that Lee is not recommended to use forward declaration and asked me
to use includes, then you agreed with the same. Again same comments !! sorry I am lost.
>> +struct mp2629_info { >> + struct device *dev; >> + struct regmap *regmap; >> +}; >> + >> +#endif
|  |