Messages in this thread Patch in this message |  | | From | Jules Irenge <> | Subject | [PATCH 10/10] trace: Replace printk and WARN_ON with WARN | Date | Fri, 27 Mar 2020 21:23:57 +0000 |
| |
Coccinelle suggests replacing printk and WARN_ON with WARN
SUGGESTION: printk + WARN_ON can be just WARN. Signed-off-by: Jules Irenge <jbi.octave@gmail.com> --- kernel/trace/trace.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 6b11e4e2150c..1fe31272ea73 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -1799,9 +1799,7 @@ static int run_tracer_selftest(struct tracer *type) /* the test is responsible for resetting too */ tr->current_trace = saved_tracer; if (ret) { - printk(KERN_CONT "FAILED!\n"); - /* Add the warning after printing 'FAILED' */ - WARN_ON(1); + WARN(1, "FAILED!\n"); return -1; } /* Only reset on passing, to avoid touching corrupted buffers */ -- 2.25.1
|  |