Messages in this thread Patch in this message |  | | From | Jules Irenge <> | Subject | [PATCH 01/10] locking/rtmutex: Remove Comparison to bool | Date | Fri, 27 Mar 2020 21:23:48 +0000 |
| |
From: Jules Irenge <jbi.octave@example.com>
Coccinelle reports a warning inside rt_mutex_slowunlock()
WARNING: Comparison to bool
To fix this, the comparison to bool is removed This not only fixes the issue but also removes the unnecessary comparison.
Remove comparison to bool
Signed-off-by: Jules Irenge <jbi.octave@example.com> --- kernel/locking/rtmutex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/locking/rtmutex.c b/kernel/locking/rtmutex.c index 851bbb10819d..7289e7b26be4 100644 --- a/kernel/locking/rtmutex.c +++ b/kernel/locking/rtmutex.c @@ -1378,7 +1378,7 @@ static bool __sched rt_mutex_slowunlock(struct rt_mutex *lock, */ while (!rt_mutex_has_waiters(lock)) { /* Drops lock->wait_lock ! */ - if (unlock_rt_mutex_safe(lock, flags) == true) + if (unlock_rt_mutex_safe(lock, flags)) return false; /* Relock the rtmutex and try again */ raw_spin_lock_irqsave(&lock->wait_lock, flags); -- 2.25.1
|  |