Messages in this thread |  | | Date | Fri, 27 Mar 2020 20:43:54 +0100 | From | Michal Kubecek <> | Subject | Re: [PATCH net-next v2 11/12] ethtool: add timestamping related string sets |
| |
On Fri, Mar 27, 2020 at 11:53:44AM -0700, Richard Cochran wrote: > On Fri, Mar 27, 2020 at 03:08:12PM +0100, Michal Kubecek wrote: > > +const char ts_tx_type_names[][ETH_GSTRING_LEN] = { > > + [HWTSTAMP_TX_OFF] = "off", > > + [HWTSTAMP_TX_ON] = "on", > > + [HWTSTAMP_TX_ONESTEP_SYNC] = "one-step-sync", > > + [HWTSTAMP_TX_ONESTEP_P2P] = "one-step-p2p", > > +}; > > Suggest "onestep-sync" and "onestep-p2p".
I copied "one-step-sync" from (userspace) ethtool but I guess we don't have to be 100% backward compatible. It would match the constant name better without dash.
Michal
> Acked-by: Richard Cochran <richardcochran@gmail.com>
|  |