lkml.org 
[lkml]   [2020]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next v2 11/12] ethtool: add timestamping related string sets
On Fri, Mar 27, 2020 at 11:53:44AM -0700, Richard Cochran wrote:
> On Fri, Mar 27, 2020 at 03:08:12PM +0100, Michal Kubecek wrote:
> > +const char ts_tx_type_names[][ETH_GSTRING_LEN] = {
> > + [HWTSTAMP_TX_OFF] = "off",
> > + [HWTSTAMP_TX_ON] = "on",
> > + [HWTSTAMP_TX_ONESTEP_SYNC] = "one-step-sync",
> > + [HWTSTAMP_TX_ONESTEP_P2P] = "one-step-p2p",
> > +};
>
> Suggest "onestep-sync" and "onestep-p2p".

I copied "one-step-sync" from (userspace) ethtool but I guess we don't
have to be 100% backward compatible. It would match the constant name
better without dash.

Michal

> Acked-by: Richard Cochran <richardcochran@gmail.com>

\
 
 \ /
  Last update: 2020-03-27 20:45    [W:0.055 / U:1.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site