Messages in this thread |  | | Subject | Re: [PATCH v4 2/5] mfd: mp2629: Add support for mps battery charger | From | saravanan sekar <> | Date | Fri, 27 Mar 2020 13:40:07 +0100 |
| |
Hi Lee, Andy
On 27/03/20 12:25 pm, Lee Jones wrote: > On Fri, 27 Mar 2020, saravanan sekar wrote: >> On 27/03/20 11:22 am, Lee Jones wrote: >>> Saravanan, Jonathan, >>> >>> On Fri, 27 Mar 2020, saravanan sekar wrote: >>>> On 27/03/20 8:55 am, Lee Jones wrote: >>>>> On Sun, 22 Mar 2020, Saravanan Sekar wrote: >>>>> >>>>>> mp2629 is a highly-integrated switching-mode battery charge management >>>>>> device for single-cell Li-ion or Li-polymer battery. >>>>>> >>>>>> Add MFD core enables chip access for ADC driver for battery readings, >>>>>> and a power supply battery-charger driver >>>>>> >>>>>> Signed-off-by: Saravanan Sekar <sravanhome@gmail.com> >>>>>> --- >>>>>> drivers/mfd/Kconfig | 9 +++ >>>>>> drivers/mfd/Makefile | 2 + >>>>>> drivers/mfd/mp2629.c | 116 +++++++++++++++++++++++++++++++++++++ >>>>>> include/linux/mfd/mp2629.h | 22 +++++++ >>>>>> 4 files changed, 149 insertions(+) >>>>>> create mode 100644 drivers/mfd/mp2629.c >>>>>> create mode 100644 include/linux/mfd/mp2629.h > [...] > >>>>>> +#ifndef __MP2629_H__ >>>>>> +#define __MP2629_H__ >>>>>> + >>>>>> +#include <linux/types.h> >>>>>> + >>>>>> +struct device; >>>>>> +struct regmap; >>>>> Why not just add the includes? >>>> Some more shared enum added in ADC driver >>> Sorry? >> I misunderstood your previous question that you are asking to remove this >> mp2629.h file >> >> "No user here. (Hint: Use forward declaration of struct device instead)" - >> review comments on V1 from Andy Shevchenko. >> So remove the includes > So Andy has reviewed, but you still don't have him on Cc? Sorry one of his hint made me removed him in CC unknowingly.
"For the future, hint: scripts/get_maintainer.pl --git --git-min-percent=67 ..."
My fault, added him in CC
> How are we meant to continue the discussion? > > As a general rule I'm not a fan of forward declarations. > > I think they should be avoided if at all possible. Ok will add includes >>>>>> +struct mp2629_info { >>>>>> + struct device *dev; >>>>>> + struct regmap *regmap; >>>>>> +}; >>>>>> + >>>>>> +#endif
|  |