[lkml]   [2020]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 10/21] clocksource: Replace setup_irq() by request_irq()
On Wed, Mar 18, 2020 at 6:42 PM Daniel Lezcano
<> wrote:

> From: afzal mohammed <>
> request_irq() is preferred over setup_irq(). The early boot setup_irq()
> invocations happen either via 'init_IRQ()' or 'time_init()', while
> memory allocators are ready by 'mm_init()'.
> Per tglx[1], setup_irq() existed in olden days when allocators were not
> ready by the time early interrupts were initialized.
> Hence replace setup_irq() by request_irq().
> Seldom remove_irq() usage has been observed coupled with setup_irq(),
> wherever that has been found, it too has been replaced by free_irq().
> A build error that was reported by kbuild test robot <>
> in the previous version of the patch also has been fixed.
> [1]
> Signed-off-by: afzal mohammed <>
> Signed-off-by: Daniel Lezcano <>
> Link:

Acked-by: Linus Walleij <>

It is definitely the right thing to do, I cannot test it right now
but if desired I can test it on my targets later in the following

Linus Walleij

 \ /
  Last update: 2020-03-27 11:27    [W:0.093 / U:0.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site