lkml.org 
[lkml]   [2020]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v3 1/4] dt-bindings: phy: renesas: usb2-phy: convert bindings to json-schema
Date
Hi Geert-san,

Thank you for your review!

> From: Geert Uytterhoeven, Sent: Friday, March 27, 2020 5:55 PM
<snip>
> > --- a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt
> > +++ /dev/null
>
> > -The phandle's argument in the PHY specifier is the INT_STATUS bit of controller:
> > -- 1 = USBH_INTA (OHCI)
> > -- 2 = USBH_INTB (EHCI)
> > -- 3 = UCOM_INT (OTG and BC)
>
> Sorry, I failed to notice during my previous review that the above information
> is lost during the conversion. I think it would be good to retain it in the
> description for #phy-cells.

I agree. I'll add it.

> With that added:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks!

Best regards,
Yoshihiro Shimoda

\
 
 \ /
  Last update: 2020-03-27 10:20    [W:0.080 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site