Messages in this thread |  | | From | "Rafael J. Wysocki" <> | Date | Tue, 24 Mar 2020 13:53:49 +0100 | Subject | Re: [PATCH v2 3/3] driver core: Replace open-coded list_last_entry() |
| |
On Tue, Mar 24, 2020 at 1:20 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > There is a place in the code where open-coded version of list entry accessors > list_last_entry() is used. > > Replace that with the standard macro. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> --- > v2: no change > drivers/base/dd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/base/dd.c b/drivers/base/dd.c > index efd0e4c16ba5..27a4d51b5bba 100644 > --- a/drivers/base/dd.c > +++ b/drivers/base/dd.c > @@ -1226,7 +1226,7 @@ void driver_detach(struct device_driver *drv) > spin_unlock(&drv->p->klist_devices.k_lock); > break; > } > - dev_prv = list_entry(drv->p->klist_devices.k_list.prev, > + dev_prv = list_last_entry(&drv->p->klist_devices.k_list, > struct device_private, > knode_driver.n_node); > dev = dev_prv->device; > -- > 2.25.1 >
|  |