Messages in this thread |  | | From | Martin Blumenstingl <> | Date | Tue, 24 Mar 2020 15:19:00 +0100 | Subject | Re: [PATCH 02/13] usb: dwc3: meson-g12a: specify phy names in soc data |
| |
On Tue, Mar 24, 2020 at 3:17 PM Neil Armstrong <narmstrong@baylibre.com> wrote: > > On 24/03/2020 15:13, Martin Blumenstingl wrote: > > Hi Neil, > > > > On Tue, Mar 24, 2020 at 11:20 AM Neil Armstrong <narmstrong@baylibre.com> wrote: > > [...] > >> +static const char *meson_a1_phy_names[] = { > >> + "usb2-phy0", "usb2-phy1" > >> +}; > > my understanding is that the A1 SoC only has usb2-phy1. > > +Cc Hanjie Lin to confirm this > > I forgot a comment here, it only has a single PHY, but still the 2 U2 PHY > controls slots... it would need a large amount of code to handle this > tweak, and leaving 2 PHYs keeps the behavior before the patchset. I just reviewed patch #3 and I now understand that it would require a large code-change I'm fine with a comment
Martin
|  |