lkml.org 
[lkml]   [2020]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 01/13] dt-bindings: usb: amlogic,meson-g12a-usb-ctrl: add the Amlogic GXL and GXM Families USB Glue Bindings
From
Date
On 24/03/2020 15:06, Martin Blumenstingl wrote:
> Hi Neil,
>
> On Tue, Mar 24, 2020 at 11:20 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
> [...]
>> --- a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml
>> +++ b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml
>> @@ -25,9 +25,13 @@ description: |
>> The Amlogic A1 embeds a DWC3 USB IP Core configured for USB2 in
>> host-only mode.
>>
>> + The Amlogic GXL & GXM SoCs doesn't embed an USB3 PHY.
>> +
>> properties:
>> compatible:
>> enum:
>> + - amlogic,meson-gxl-usb-ctrl
>> + - amlogic,meson-gxm-usb-ctrl
>> - amlogic,meson-g12a-usb-ctrl
>> - amlogic,meson-a1-usb-ctrl
> the phy-names property is described below which you don't update
> please add usb2-phy2 to the list of allowed phy-names so the dt
> binding validation for the .dtsi patche (#9) won't complain

Missed this one, thanks !

Neil

>
> With that fixed:
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>
>
> Martin
>

\
 
 \ /
  Last update: 2020-03-24 15:11    [W:0.072 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site