lkml.org 
[lkml]   [2020]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] MIPS: Loongson: Add model name to /proc/cpuinfo
On Wed, 11 Mar 2020, Jiaxun Yang wrote:

> __cpu_name[] will be displayed as "cpu model" in cpuinfo, however
> in x86 world, the name line is started with "model name".
> Most user applications like lscpu, hwinfo is following x86's rule, we don't have superpower to move all of them.
>
> Also rename "cpu model" will break current ABI, so just create a new array
> for it would be a better option.

Well, /proc/cpuinfo is not an ABI, it's meant for human interaction (use
`sysfs' for machine processing).

If tools want to use it anyway, then fine, but they need to adapt to the
relative volatility of the free-form text interface, and also learn all
the world is not x86 (just like all the MIPS world is not Loongson, so if
you argue about adding effectively a duplicate field, then that would have
to be applied across all the platforms). IOW fix the tool and do not work
its deficiencies around in the kernel just because it seems easier for you
to do.

Here's how example /proc/cpuinfo looks like on RISC-V/Linux BTW:

processor : 0
hart : 1
isa : rv64imafdc
mmu : sv39
uarch : sifive,rocket0

[...]

-- every Linux platform is different in this respect and tools have to
live with that.

Maciej

\
 
 \ /
  Last update: 2020-03-20 22:25    [W:0.047 / U:1.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site