lkml.org 
[lkml]   [2020]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 4/9] sched/topology: Kill SD_LOAD_BALANCE
Date
On 11.03.20 19:15, Valentin Schneider wrote:
> That flag is set unconditionally in sd_init(), and no one checks for it
> anymore. Remove it.

Why not merge 3/9 and 4/9 ?

[...]

> diff --git a/include/linux/sched/topology.h b/include/linux/sched/topology.h
> index f341163fedc9..8de2f9744569 100644
> --- a/include/linux/sched/topology.h
> +++ b/include/linux/sched/topology.h
> @@ -11,21 +11,20 @@
> */
> #ifdef CONFIG_SMP
>
> -#define SD_LOAD_BALANCE 0x0001 /* Do load balancing on this domain. */
> -#define SD_BALANCE_NEWIDLE 0x0002 /* Balance when about to become idle */

[...]

> -#define SD_OVERLAP 0x2000 /* sched_domains of this level overlap */
> -#define SD_NUMA 0x4000 /* cross-node balancing */
> +#define SD_BALANCE_NEWIDLE 0x0001 /* Balance when about to become idle */

IMHO, changing the values of the remaining SD flags will break lots of
userspace scripts.

[...]

\
 
 \ /
  Last update: 2020-03-19 11:30    [W:0.111 / U:0.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site