lkml.org 
[lkml]   [2020]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] soundwire: stream: only change state if needed
From
Date


On 3/17/20 8:04 AM, Srinivas Kandagatla wrote:
>
>
> On 17/03/2020 12:22, Pierre-Louis Bossart wrote:
>>
>> The change below would be an error case for Intel, so it's probably
>> better if we go with your suggestion. You have a very specific state
>> handling due to your power amps and it's probably better to keep it
>> platform-specific.
>
> Just trying to understand, why would it be error for Intel case?
>
> IMO, If stream state is SDW_STREAM_ENABLED that also implicit that its
> prepared too. Similar thing with SDW_STREAM_DEPREPARED.
> Isn't it?

the stream state is a scalar value, not a mask. The state machine only
allows transition from CONFIGURED TO PREPARED or from DEPREPARED TO
PREPARED, or DISABLED to PREPARED.
There is no allowed transition from ENABLED TO PREPARED, you have to go
through the DISABLED state and make sure a bank switch occurred, and
re-do a bank switch to prepare again.

\
 
 \ /
  Last update: 2020-03-17 15:25    [W:0.053 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site