lkml.org 
[lkml]   [2020]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] soundwire: stream: only change state if needed
From
Date


On 17/03/2020 12:22, Pierre-Louis Bossart wrote:
> Hi Srinivas,
>
>> This patch did not work for me as it is as wsa881x codec does prepare
>> and enable in one function, which breaks some of the assumptions in
>> this patch.
>
> Ah yes, if two transitions happen in the same DAI callback that wouldn't
> work indeed. We should probably add this restriction to the state
> machine documentation, the suggested mapping from ASoC DAI states to
> stream states did not account for compound cases.
>
>> However with below change I could get it working without moving stream
>> handling to machine driver.
>
> The change below would be an error case for Intel, so it's probably
> better if we go with your suggestion. You have a very specific state
> handling due to your power amps and it's probably better to keep it
> platform-specific.
>
> Can you confirm though that this patch works fine if you move all the
> stream transitions to the machine driver? That should be a no-op but
> better make sure there's no misunderstanding.

yes, it works with this patch + moving wsa stream handing to machine driver.

--srini
>
> Thanks
> -Pierre

\
 
 \ /
  Last update: 2020-03-17 13:44    [W:0.071 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site