lkml.org 
[lkml]   [2020]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCHv6 2/3] mm/gup: fix omission of check on FOLL_LONGTERM in gup fast path
On Mon, Mar 16, 2020 at 4:55 PM Christoph Hellwig <hch@infradead.org> wrote:
>
[...]
>
> Wrong indentation. We either align two tabs for continuation
> statements, or after the opening brace of the previous line. With a
> likely or unlikely thrown in the former IMHO looks much better. E.g.
>
> if (unlikely(flags & FOLL_LONGTERM) &&
> is_migrate_cma_page(page))
> return NULL;
>
OK, thanks. I will send out V7 to fix it.

Regards,
Pingfan

\
 
 \ /
  Last update: 2020-03-17 12:46    [W:0.071 / U:0.736 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site