lkml.org 
[lkml]   [2020]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 103/123] pinctrl: core: Remove extra kref_get which blocks hogs being freed
    Date
    From: Charles Keepax <ckeepax@opensource.cirrus.com>

    commit aafd56fc79041bf36f97712d4b35208cbe07db90 upstream.

    kref_init starts with the reference count at 1, which will be balanced
    by the pinctrl_put in pinctrl_unregister. The additional kref_get in
    pinctrl_claim_hogs will increase this count to 2 and cause the hogs to
    not get freed when pinctrl_unregister is called.

    Fixes: 6118714275f0 ("pinctrl: core: Fix pinctrl_register_and_init() with pinctrl_enable()")
    Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
    Link: https://lore.kernel.org/r/20200228154142.13860-1-ckeepax@opensource.cirrus.com
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/pinctrl/core.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/drivers/pinctrl/core.c
    +++ b/drivers/pinctrl/core.c
    @@ -2025,7 +2025,6 @@ static int pinctrl_claim_hogs(struct pin
    return PTR_ERR(pctldev->p);
    }

    - kref_get(&pctldev->p->users);
    pctldev->hog_default =
    pinctrl_lookup_state(pctldev->p, PINCTRL_STATE_DEFAULT);
    if (IS_ERR(pctldev->hog_default)) {

    \
     
     \ /
      Last update: 2020-03-17 12:20    [W:4.172 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site