[lkml]   [2020]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH 5.5 135/151] i2c: gpio: suppress error on probe defer
    From: Hamish Martin <>

    commit 3747cd2efe7ecb9604972285ab3f60c96cb753a8 upstream.

    If a GPIO we are trying to use is not available and we are deferring
    the probe, don't output an error message.
    This seems to have been the intent of commit 05c74778858d
    ("i2c: gpio: Add support for named gpios in DT") but the error was
    still output due to not checking the updated 'retdesc'.

    Fixes: 05c74778858d ("i2c: gpio: Add support for named gpios in DT")
    Signed-off-by: Hamish Martin <>
    Acked-by: Linus Walleij <>
    Signed-off-by: Wolfram Sang <>
    Signed-off-by: Greg Kroah-Hartman <>

    drivers/i2c/busses/i2c-gpio.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/i2c/busses/i2c-gpio.c
    +++ b/drivers/i2c/busses/i2c-gpio.c
    @@ -348,7 +348,7 @@ static struct gpio_desc *i2c_gpio_get_de
    if (ret == -ENOENT)
    retdesc = ERR_PTR(-EPROBE_DEFER);

    - if (ret != -EPROBE_DEFER)
    + if (PTR_ERR(retdesc) != -EPROBE_DEFER)
    dev_err(dev, "error trying to get descriptor: %d\n", ret);

    return retdesc;

     \ /
      Last update: 2020-03-17 12:14    [W:4.346 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site