lkml.org 
[lkml]   [2020]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH v5 3/7] PCI: rcar: Fix calculating mask for PCIEPAMR register
    Date
    Hi Prabhakar-san,

    Thank you for the patch!

    > From: Lad Prabhakar, Sent: Saturday, February 29, 2020 12:41 AM
    >
    > The mask value was calculated incorrectly for PCIEPAMR register if the
    > size was less than 128 bytes. Fix this issue by adding a check on size.
    >
    > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
    > ---
    > drivers/pci/controller/pcie-rcar.c | 5 ++++-
    > 1 file changed, 4 insertions(+), 1 deletion(-)
    >
    > diff --git a/drivers/pci/controller/pcie-rcar.c b/drivers/pci/controller/pcie-rcar.c
    > index 41275f9..90d47b21 100644
    > --- a/drivers/pci/controller/pcie-rcar.c
    > +++ b/drivers/pci/controller/pcie-rcar.c
    > @@ -75,7 +75,10 @@ void rcar_pcie_set_outbound(int win, void __iomem *base,
    > * keeps things pretty simple.
    > */
    > size = resource_size(res);
    > - mask = (roundup_pow_of_two(size) / SZ_128) - 1;
    > + if (size > 128)
    > + mask = (roundup_pow_of_two(size) / SZ_128) - 1;
    > + else
    > + mask = 0x0;
    > rcar_pci_write_reg(base, mask << 7, PCIEPAMR(win));

    This patch seems OK. I think rebasing is needed though. Anyway,

    Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

    Best regards,
    Yoshihiro Shimoda

    > if (res->flags & IORESOURCE_IO)
    > --
    > 2.7.4

    \
     
     \ /
      Last update: 2020-03-17 08:32    [W:8.471 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site