lkml.org 
[lkml]   [2020]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 0/6] kselftest: add fixture parameters
On Mon, Mar 16, 2020 at 03:59:17PM -0700, Jakub Kicinski wrote:
> On Mon, 16 Mar 2020 15:56:40 -0700 Jakub Kicinski wrote:
> > Hi!
> >
> > Shuah please consider applying to the kselftest tree.
> >
> > This set is an attempt to make running tests for different
> > sets of data easier. The direct motivation is the tls
> > test which we'd like to run for TLS 1.2 and TLS 1.3,
> > but currently there is no easy way to invoke the same
> > tests with different parameters.
> >
> > Tested all users of kselftest_harness.h.
> >
> > v2:
> > - don't run tests by fixture
> > - don't pass params as an explicit argument
> >
> > v3:
> > - go back to the orginal implementation with an extra
> > parameter, and running by fixture (Kees);
> > - add LIST_APPEND helper (Kees);
> > - add a dot between fixture and param name (Kees);
> > - rename the params to variants (Tim);
> >
> > v1: https://lore.kernel.org/netdev/20200313031752.2332565-1-kuba@kernel.org/
> > v2: https://lore.kernel.org/netdev/20200314005501.2446494-1-kuba@kernel.org/
>
> Ugh, sorry I forgot to realign things after the rename :S
>
> I'll send a whitespace-only v4 in a hour, allowing a little bit
> of time in case there are some comments already.

No worries! I think a few small changes are needed for a v5 (please
carry my Acked-bys with for v5). Thanks for working on this; I love it!
:)

-Kees

--
Kees Cook

\
 
 \ /
  Last update: 2020-03-17 21:48    [W:5.490 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site