lkml.org 
[lkml]   [2020]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net 1/2] Revert "net: bcmgenet: use RGMII loopback for MAC reset"
From
Date
On 3/16/2020 7:21 PM, Florian Fainelli wrote:
>
>
> On 3/16/2020 2:44 PM, Doug Berger wrote:
>> This reverts commit 3a55402c93877d291b0a612d25edb03d1b4b93ac.
>>
>> This is not a good solution when connecting to an external switch
>> that may not support the isolation of the TXC signal resulting in
>> output driver contention on the pin.
>>
>> A different solution is necessary.
>>
>> Signed-off-by: Doug Berger <opendmb@gmail.com>
>
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
>
> Did you want this to be tagged with:
>
> Fixes: 3a55402c9387 ("net: bcmgenet: use RGMII loopback for MAC reset")
>
> so as to make it more explicit how the two commits relate to each other?
I wasn't sure how best to tag this commit.

It seems odd to indicate that the reversion of a commit fixes the commit
that is reverted, but maybe that is the best way. It is more accurate to
say that the reversion of the commit reintroduces the problem that it
was intended to address, and therefore doesn't fix anything but rather
trades one problem for another.

It is clearer that the second commit fixes the original issue and so I
tagged it accordingly, but it is far less clear how a reversion like
this should be tagged.

If you think it is clearer to tag this as you describe I have no objection.

>
> Thanks!
> --
> Florian
>
Thank you for taking a look at this and for the feedback,
Doug

\
 
 \ /
  Last update: 2020-03-17 20:41    [W:0.037 / U:0.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site