lkml.org 
[lkml]   [2020]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 06/10] KVM: nVMX: Convert local exit_reason to u16 in ...enter_non_root_mode()
From
Date
On 17/03/20 06:29, Sean Christopherson wrote:
>>>
>>> load_vmcs12_host_state(vcpu, vmcs12);
>>> - vmcs12->vm_exit_reason = exit_reason | VMX_EXIT_REASONS_FAILED_VMENTRY;
>>> + vmcs12->vm_exit_reason = VMX_EXIT_REASONS_FAILED_VMENTRY | exit_reason;
>> My personal preference would be to do
>> (u32)exit_reason | VMX_EXIT_REASONS_FAILED_VMENTRY
>> instead but maybe I'm just not in love with implicit type convertion in C.
> Either way works for me. Paolo?
>

Flip a coin? :) I think your version is fine.

Paolo

\
 
 \ /
  Last update: 2020-03-17 18:41    [W:0.100 / U:1.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site