Messages in this thread |  | | Date | Mon, 16 Mar 2020 16:32:02 +0100 | From | Thomas Bogendoerfer <> | Subject | Re: [PATCH v2] MIPS: pass non-NULL dev_id on shared request_irq() |
| |
On Sat, Mar 14, 2020 at 01:43:12PM +0530, afzal mohammed wrote: > Recently all usages of setup_irq() was replaced by request_irq(). > request_irq() does a few sanity checks that were not done in > setup_irq(), if they fail irq registration will fail. One of the check > is to ensure that non-NULL dev_id is passed in the case of shared irq. > This caused malta on qemu to hang. > > Fix it by passing handler as dev_id to all request_irq()'s that are > shared. For sni, instead of passing non-NULL dev_id, remove shared irq > flags. > > Fixes: ac8fd122e070 ("MIPS: Replace setup_irq() by request_irq()") > Reported-by: Nathan Chancellor <natechancellor@gmail.com> > Suggested-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de> > Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail.com>
thank you, applied to mips-next.
Thomas.
-- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
|  |