lkml.org 
[lkml]   [2020]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 0/2] selftests/harness: Handle timeouts cleanly
From
Date
Hi Kees,

On 3/11/20 3:17 PM, Kees Cook wrote:
> When a selftest would timeout before, the program would just fall over
> and no accounting of failures would be reported (i.e. it would result in
> an incomplete TAP report). Instead, add an explicit SIGALRM handler to
> cleanly catch and report the timeout.
>
> Before:
>
> [==========] Running 2 tests from 2 test cases.
> [ RUN ] timeout.finish
> [ OK ] timeout.finish
> [ RUN ] timeout.too_long
> Alarm clock
>
> After:
>
> [==========] Running 2 tests from 2 test cases.
> [ RUN ] timeout.finish
> [ OK ] timeout.finish
> [ RUN ] timeout.too_long
> timeout.too_long: Test terminated by timeout
> [ FAIL ] timeout.too_long
> [==========] 1 / 2 tests passed.
> [ FAILED ]
>

This is good info. to capturein the commit logs for the patches.
Please add them and send v2. You can also fix the subject prefix
at the same time :)

thanks,
-- Shuah

\
 
 \ /
  Last update: 2020-03-13 18:26    [W:0.055 / U:3.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site