[lkml]   [2020]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [patch] mm, oom: prevent soft lockup on memcg oom for UP systems
David Rientjes wrote:
> > By the way, will you share the reproducer (and how to use the reproducer) ?
> >
> On an UP kernel with swap disabled, you limit a memcg to 100MB and start
> three processes that each fault 40MB attached to it. Same reproducer as
> the "mm, oom: make a last minute check to prevent unnecessary memcg oom
> kills" patch except in that case there are two cores.

I'm not a heavy memcg user. Please provide steps for reproducing your problem
in a "copy and pastable" way (e.g. bash script, C program).

> > @@ -1576,6 +1576,7 @@ static bool mem_cgroup_out_of_memory(struct mem_cgroup *memcg, gfp_t gfp_mask,
> > */
> > ret = should_force_charge() || out_of_memory(&oc);
> > mutex_unlock(&oom_lock);
> > + schedule_timeout_killable(1);
> > return ret;
> > }
> >
> If current was process chosen for oom kill, this would actually induce the
> problem, not fix it.

Why? Memcg OOM path allows using forced charge path if should_force_charge() == true.

Since your lockup report

Call Trace:

says that allocating thread was calling try_to_free_mem_cgroup_pages() from try_charge(),
allocating thread must be able to reach mem_cgroup_out_of_memory() from mem_cgroup_oom()
from try_charge(). And actually

Memory cgroup out of memory: Killed process 808 (repro) total-vm:41944kB, anon-rss:35344kB, file-rss:504kB, shmem-rss:0kB, UID:0 pgtables:108kB oom_score_adj:0

says that allocating thread did reach mem_cgroup_out_of_memory(). Then, allocating thread
must be able to sleep at mem_cgroup_out_of_memory() if schedule_timeout_killable(1) is

Also, if current process was chosen for OOM-kill, current process will be able to leave
try_charge() due to should_force_charge() == true, won't it?

Thus, how can "this would actually induce the problem, not fix it." happen?
If your problem is that something keeps allocating threads away from reaching
should_force_charge() check, please explain the mechanism. If that is explained,
I would agree that schedule_timeout_killable(1) in mem_cgroup_out_of_memory()
won't help.

 \ /
  Last update: 2020-03-13 01:16    [W:0.128 / U:3.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site